Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle modules build: Allow Java 20 #33063

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

snazy
Copy link
Contributor

@snazy snazy commented May 2, 2023

Gradle's Kotlin scripts don't (yet) build using Java 20. Force Java 11 for build scripts.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels May 2, 2023
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented May 3, 2023

@snazy could you check if the failure is related?

Gradle's Kotlin scripts don't (yet) build against Java 20. Force Java 11 for build scripts.
@snazy snazy force-pushed the gradle-java-20 branch from 1751260 to 5e1b9da Compare May 3, 2023 09:13
@snazy
Copy link
Contributor Author

snazy commented May 3, 2023

sigh yea, related. Updated the Gradle script to work around that.

@quarkus-bot
Copy link

quarkus-bot bot commented May 3, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 113b0bd into quarkusio:main May 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 4, 2023
@snazy snazy deleted the gradle-java-20 branch May 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants